feat: add external_resources column to waypoints

[florentcadot]

c2corg/c2c_ui#3697
Associated frontend PR: c2corg/c2c_ui#3846

How to test:

Run the added migration using docker-compose exec api .build/venv/bin/alembic upgrade head
Pull the associated front branch: feature/#3697-add-waypoints-external-resources

From the front app, create a new waypoint and fill the external_resources field. Then update the external resources of this.

[brunobesson]

LGTM, although I am not fluen with the backend. But the modifications ook consistent, and you tested it already :)

[lbesson]

lgtm, maybe we could add some unit tests around this? That shoudln't be too complicated (mostly copy pasting how it's done with other documents?)

[florentcadot]

lgtm, maybe we could add some unit tests around this? That shoudln't be too complicated (mostly copy pasting how it's done with other documents?)

You're right!

I've added a simple model unit test in c2corg_api/tests/models/test_waypoint.py.
Do you want me to test if Waypoint instantiation with wrong local external_resource does not work ?
Maybe I should add some tests in views/test_waypoint as well ?

Thanks for the review guys 😄

[lbesson]

the more tests, the better, but I'll let you judge to what extent you want to go :)

imho you can merge when you feel so

[brunobesson]

Could you lint the files so I can merge?

[florentcadot]

Could you lint the files so I can merge?

Do you need me to also fix the codacy error or it's fine ?

(It's just a convenient way to destructure the tuple returned by the function)

[eddy-geek]

Do you need me to also fix the codacy error or it's fine ?

(It's just a convenient way to destructure the tuple returned by the function)

FYI _ as variable name is a usual way to signal you don't use it, tools will usually understand it.

ie

(_, waypoint) = self.put_success_all( ...