Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dockerfile linting #42

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add dockerfile linting #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c60134
Add dockerfile linting
May 1, 2022
6877c79
Consolidate RUN steps in Dockerfile
May 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/eslint-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,19 @@ jobs:
needs: branch_naming
steps:
- uses: actions/checkout@v2

- name: Lint Dockerfile
uses: hadolint/hadolint-action@master
with:
recursive: true
dockerfile: "Dockerfile"

- uses: actions/setup-node@v2
with:
node-version: '16'

- name: Install eslint
run: npm install -g eslint

- name: Run ESLint
run: npm run lint
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ WORKDIR /app
ENV PATH /app/node_modules/.bin:$PATH
COPY package.json ./
COPY package-lock.json ./
RUN npm i -g npm --silent
RUN npm i --silent
RUN npm install react-scripts -g --silent
RUN npm i -g npm --silent \
&& npm i --silent \
&& npm install react-scripts -g --silent
COPY . ./
RUN npm run build

Expand Down