Skip to content

Commit

Permalink
Bug 25777: Disable misleading datatables table information display z3950
Browse files Browse the repository at this point in the history
This patch disables the table information display on z3950_search.pl,
since it only includes search result counts for that page, which is
misleading to end users.

To test:
1)  Do not apply the patch
2)  Do a Z39.50 search from cataloguing for "test" against Library of
    Congress.
3)  Note the bottom of the page says "Show 1 to 20 of 20" and
    "Showing page 1 of 501"
4)  Do a Z39.50 search from Acquisitions for "test" against Library of
    Congress (Acquisitions -> Vendor -> Basket -> Add to basket -> From
    external source).
5)  Apply the patch and restart Plack
6)  Repeat Step #2
7)  Note the bottom of the page now only says "Showing page 1 of 501"
8)  Note the search bar is gone
9)  Repeat step #4
10) Note the bottom of the page now only says "Showing page 1 of 501"
11) Note the search bar is gone

Squashed and mixed authorship added below
Co-authored-by: Owen Leonard <[email protected]>
Co-authored-by: Martin Renvoize <[email protected]>

Signed-off-by: Owen Leonard <[email protected]>
Signed-off-by: David Cook <[email protected]>
Signed-off-by: Martin Renvoize <[email protected]>

Signed-off-by: Jonathan Druart <[email protected]>
(cherry picked from commit 2a2a04a)
Signed-off-by: Fridolin Somers <[email protected]>
(cherry picked from commit 1e03555)

Signed-off-by: Andrew Fuerste-Henry <[email protected]>
  • Loading branch information
minusdavid authored and AndrewBWS committed Mar 5, 2021
1 parent 75efe2e commit 168a435
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color :
{ "aTargets": [ 1 ], "sType": "nsb-nse" },
],
"aaSorting": [[ 1, "asc" ]],
"bPaginate": false
"bPaginate": false,
"searching": false,
"bInfo":false
}));
});
</script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,9 @@
{ "aTargets": [ 1 ], "sType": "nsb-nse" },
],
"aaSorting": [[ 1, "asc" ]],
"bPaginate": false
"bPaginate": false,
"searching": false,
"bInfo":false
}, columns_settings );
});

Expand Down

0 comments on commit 168a435

Please sign in to comment.