Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrelation #160

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
Open

Autocorrelation #160

wants to merge 12 commits into from

Conversation

ekvdg
Copy link

@ekvdg ekvdg commented Jan 30, 2019

This implements new metafeatures including autocorrelation, cardinality at 2,3,4, and binary features. It also updates the way that numeric and categorical cardinalities are being calculated.

@bjschoenfeld bjschoenfeld requested review from epeters3 and removed request for rlaboulaye August 5, 2019 21:56
@bjschoenfeld bjschoenfeld assigned bjschoenfeld and unassigned epeters3 Aug 7, 2019
@bjschoenfeld
Copy link
Member

The cardinalities in the metafeatures.json and the code that computes them need to be cleaned up. I want to fix this after the refactor that is coming soon. Also, I want to separate this from the autocorrelation PR. I will make a separate PR for each.

@epeters3
Copy link
Contributor

As requested @bjschoenfeld, I've fixed and cleaned up this PR. It should be ready for your review now.

@codecov-io
Copy link

codecov-io commented Nov 21, 2019

Codecov Report

Merging #160 into develop will decrease coverage by 0.23%.
The diff coverage is 89.18%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
- Coverage    92.36%   92.13%   -0.24%     
===========================================
  Files           13       13              
  Lines          760      788      +28     
===========================================
+ Hits           702      726      +24     
- Misses          58       62       +4
Impacted Files Coverage Δ
metalearn/metafeatures/metafeatures.py 95.87% <100%> (+0.03%) ⬆️
metalearn/metafeatures/simple_metafeatures.py 100% <100%> (ø) ⬆️
metalearn/metafeatures/statistical_metafeatures.py 55% <66.66%> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92e8a0d...cd5ed74. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants