-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor modifier #104
Draft
ebensonm
wants to merge
59
commits into
python-cli-refactor
Choose a base branch
from
refactor-modifier
base: python-cli-refactor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Refactor modifier #104
Changes from 51 commits
Commits
Show all changes
59 commits
Select commit
Hold shift + click to select a range
99c7b5b
Add query and generator class
ebensonm deee5fa
Untested seed swap functionality
ebensonm cdf770a
Minor syntax fixes
ebensonm 082429a
Merge branch 'python-cli-refactor' into refactor-modifier
ebensonm b323c1f
Unit test, and job maker
ebensonm fdd2813
functions to execute D3M runtime evaluate via cli
clarkjoe 275cbc6
added data_prep_pipelines
clarkjoe 9b02988
renamed execute --> evaluate. created blank file for new implementati…
clarkjoe a9f264d
Merge branch 'experimenter-to-d3m-refactor' of https://github.com/byu…
ebensonm a0c9991
Bug fixes and queueing
ebensonm d678e2b
Merge branch 'python-cli-refactor' into refactor-modifier
ebensonm e565325
Merge branch 'python-cli-refactor' into experimenter-to-d3m-refactor
clarkjoe a4cc817
Syntax fixes and return paths from query
ebensonm 5f6dfb0
Merge branch 'experimenter-to-d3m-refactor' of https://github.com/byu…
ebensonm 991ad7f
setup.py updates
ebensonm 83cceb4
added function to save pipeline_run docs to DB.
clarkjoe 5c4bb38
updated documentation
clarkjoe 2635fdd
setup.py add dependencies
ebensonm aea187d
New file
ebensonm ba5089a
fixed condition typo. renamed file
clarkjoe e3cc010
Merge branch 'experimenter-to-d3m-refactor' of https://github.com/byu…
ebensonm 62d639e
Update job maker in the seed swap functionality
ebensonm 37d94bc
implemented review suggestions
clarkjoe d308e92
setup.py elasticsearch and working queue/enqueue
fe3ba99
Merging branches and evaluate updates
ebensonm 6edfb62
D3M configuration variables
ebensonm a18d859
Fixed merge from python-cli-refactor
ebensonm dc35a7f
Merge branch 'config-d3m' of https://github.com/byu-dml/d3m-experimen…
ebensonm 4f8cfa1
fix environment variables and pipeline run to dict for saving
ebensonm 92047d0
Working queue with queue refactor
78b9605
Added job count and worker info tracking for queue status command
ebensonm 43d06c9
Merge branch 'queue-status-update' of https://github.com/byu-dml/d3m-…
ebensonm c8c7cc4
rq-worker Popen commands updated
1a56219
Updated paths for saving pipelines and pipeline runs, queue and evalu…
68303e0
Merge fix and refactor fitting
ebensonm c9b0b77
experimenter logging updates
075844c
Experimenter and queue updates
ebensonm 9d06273
Merge from python-cli-refactor
ebensonm 9b3e649
Working queue and pipeline run local
ebensonm a53478c
Minor typos, need to update queue and query
d0fe148
Updates beginning datapreparation functionality
ebensonm f48abcb
Merge branch 'refactor-modifier' of https://github.com/byu-dml/d3m-ex…
ebensonm 8c26b4a
Working with test and when the data preparation is explicitly defined…
ebensonm 614be91
Bug fixes for remote work
ce3d768
Added data preparation checks for d3m module
ebensonm 9ce7db7
Minor changes to query, still failed pipelines that probably should n…
6165dbd
More robust data preparation and scoring pipelines from pipeline run
ebensonm 5208a46
Unnecessary commenting in _run_seed_test
ebensonm c59ad21
query changes for data params and scoring params
500ea10
Adding data params and scoring params to pipeline run cli works locally
ebensonm 5c90be4
using data and scoring params working remotely
c3b4b60
Working on merge suggestions
ebensonm a0bd988
Merge branch 'refactor-modifier' of https://github.com/byu-dml/d3m-ex…
ebensonm 55e8ce7
First round of suggested changes (mostly on runtime.py)
ebensonm 5777cd8
Cleaned query.py and added tests to test_modifier
ebensonm a235dfb
Test Updates and query cleaning
ebensonm 635b1c0
docker compose update and finish suggested changes
ebensonm 1e5a946
Fix tests and generator part of the modify generator
ebensonm 3714ac1
Add runtime and old execute pipeline files
ebensonm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,3 +13,4 @@ RQ_QUEUES="default" | |
|
||
D3M_DB_SUBMITTER=submitter_name | ||
D3M_DB_TOKEN=token | ||
SAVE_TO_D3M=false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you need to mount the experimenter code as a volume?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am actually not sure if the last mount is necessary. The other two are needed to show the worker where to get the data and put the data. I will run some tests with and without the /d3m-experimenter volume mount before resolving this. Can the worker use experimenter functionality without being in the experimenter?