Fix string array length comparison causing index out of bound panic in index.go hasPrefix() #2

EmmaLouise2018 · 2019-07-22T14:33:34Z

Reported by issue #1

… in index.go hasPrefix()

bytewatch · 2019-10-06T05:22:47Z

index.go

@@ -75,7 +75,7 @@ func (o *IndexDef) changeColumn(originalName, newName string) {
 }

 func (o *IndexDef) hasPrefix(columns []string) bool {
-	if len(o.Columns) < len(columns) {
+	if len(o.Columns) > len(columns) {


You should not modify this condition. If o.Columns is longger than columns, it may has a prefix of columns.
You should modify the for iteration.

Fix string array length comparision causing index out of bound panics…

4a4e6e7

… in index.go hasPrefix()

bytewatch reviewed Oct 6, 2019

View reviewed changes

EmmaLouise2018 closed this May 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix string array length comparison causing index out of bound panic in index.go hasPrefix() #2

Fix string array length comparison causing index out of bound panic in index.go hasPrefix() #2

EmmaLouise2018 commented Jul 22, 2019

bytewatch Oct 6, 2019 •

edited

Loading

Fix string array length comparison causing index out of bound panic in index.go hasPrefix() #2

Fix string array length comparison causing index out of bound panic in index.go hasPrefix() #2

Conversation

EmmaLouise2018 commented Jul 22, 2019

bytewatch Oct 6, 2019 • edited Loading

Choose a reason for hiding this comment

bytewatch Oct 6, 2019 •

edited

Loading