update go and change group membership check

Signed-off-by: bytemare <[email protected]>

go.mod

@@ -1,6 +1,6 @@
 module github.com/bytemare/crypto
 
-go 1.22.2
+go 1.23.1
 
 require (
 	filippo.io/edwards25519 v1.1.0

internal/nist/element.go

@@ -55,12 +55,7 @@ func (e *Element[Point]) Group() byte {
 		return IdentifierP521
 	}
 
-	panic(
-		fmt.Sprintf(
-			"invalid group type, expected *nistec.P256Point/P384Point/P521Point, got %v",
-			reflect.TypeFor[Point](),
-		),
-	)
+	panic(fmt.Sprintf("invalid point type %v", reflect.TypeFor[Point]()))
 }
 
 // Base sets the element to the group's base point a.k.a. canonical generator.
@@ -89,7 +84,7 @@ func (e *Element[Point]) Double() internal.Element {
 	return e
 }
 
-// negateSmall returns the compressed byte encoding of the negated element e with 5 allocs in 13000 ns/op.
+// negateSmall returns the compressed byte encoding of the negated element e with 5 allocations in 13000 ns/op.
 func (e *Element[Point]) negateSmall() []byte {
 	enc := e.p.BytesCompressed()
 

internal/nist/scalar.go

@@ -50,16 +50,16 @@ func (s *Scalar) assert(scalar internal.Scalar) *Scalar {
 
 // Group returns the group's Identifier.
 func (s *Scalar) Group() byte {
-	switch s.field.ByteLen() {
-	case 32:
+	switch *s.field {
+	case p256.scalarField:
 		return IdentifierP256
-	case 48:
+	case p384.scalarField:
 		return IdentifierP384
-	case 66:
+	case p521.scalarField:
 		return IdentifierP521
 	}
 
-	panic("invalid group type, expected nistec.P256Point/P384Point/P521Point")
+	panic(fmt.Sprintf("invalid field order for scalar %s", s.field.Order().String()))
 }
 
 // Zero sets s to 0, and returns it.