New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't register file fd in `File::from_std` #277

Merged

ihciah merged 1 commit into bytedance:master from NKID00:fix-276

Aug 7, 2024

Contributor

NKID00 commented Jul 28, 2024

Closes #276. Also adds a unit test.

CLAassistant commented Jul 28, 2024 •

edited

Loading

All committers have signed the CLA.

Collaborator

Xuanwo commented Aug 2, 2024

Thanks a lot for this PR, I'm willing to help review this PR until #281 get fixed so we have a clean CI status.

ihciah approved these changes

View reviewed changes

Member

ihciah left a comment

I met this issue for a while, thanks for fixing it!


          fix: don't register file fd

dec942e

ihciah force-pushed the fix-276 branch from 71e7b86 to dec942e Compare

August 7, 2024 07:28

ihciah merged commit 5118537 into bytedance:master

25 checks passed

NKID00 deleted the fix-276 branch

August 8, 2024 13:00

renovate bot referenced this pull request in spiraldb/vortex


          chore(deps): update rust crate monoio to v0.2.4 (#656)

44b0480

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [monoio](https://togithub.com/bytedance/monoio) |
workspace.dependencies | patch | `0.2.3` -> `0.2.4` |

---

### Release Notes

<details>
<summary>bytedance/monoio (monoio)</summary>

### [`v0.2.4`](https://togithub.com/bytedance/monoio/releases/tag/0.2.4)

[Compare
Source](https://togithub.com/bytedance/monoio/compare/0.2.3...0.2.4)

#### What's Changed

- readme: typo fix by [@&#8203;tshepang](https://togithub.com/tshepang)
in
[https://github.com/bytedance/monoio/pull/258](https://togithub.com/bytedance/monoio/pull/258)
- enhance: remove redundant check and improve efficiency by
[@&#8203;ihciah](https://togithub.com/ihciah) in
[https://github.com/bytedance/monoio/pull/260](https://togithub.com/bytedance/monoio/pull/260)
- fix: read_u128\_le() returns u16 instead of u128 . by
[@&#8203;liuxin231](https://togithub.com/liuxin231) in
[https://github.com/bytedance/monoio/pull/262](https://togithub.com/bytedance/monoio/pull/262)
- Fix docs.rs build by [@&#8203;hatoo](https://togithub.com/hatoo) in
[https://github.com/bytedance/monoio/pull/264](https://togithub.com/bytedance/monoio/pull/264)
- Feat: BoxFuture which implements Send by
[@&#8203;har23k](https://togithub.com/har23k) in
[https://github.com/bytedance/monoio/pull/271](https://togithub.com/bytedance/monoio/pull/271)
- ci/fix: modify ci.yml to let `cargo fmt/clippy` only runs on nightly
channel by [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/273](https://togithub.com/bytedance/monoio/pull/273)
- feat(op, fs): ✨ Intergated `statx` into monoio by
[@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/268](https://togithub.com/bytedance/monoio/pull/268)
- ci: Make rustfmt and clippy happy by
[@&#8203;Xuanwo](https://togithub.com/Xuanwo) in
[https://github.com/bytedance/monoio/pull/279](https://togithub.com/bytedance/monoio/pull/279)
- docs: correct JoinHandle link in the doc of spawn() by
[@&#8203;SteveLauC](https://togithub.com/SteveLauC) in
[https://github.com/bytedance/monoio/pull/265](https://togithub.com/bytedance/monoio/pull/265)
- ci: using main branch of cross by
[@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/283](https://togithub.com/bytedance/monoio/pull/283)
- make clippy happy by [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt)
in
[https://github.com/bytedance/monoio/pull/284](https://togithub.com/bytedance/monoio/pull/284)
- ci: Disable test for i686 unknown linux target by
[@&#8203;Xuanwo](https://togithub.com/Xuanwo) in
[https://github.com/bytedance/monoio/pull/286](https://togithub.com/bytedance/monoio/pull/286)
- fix: don't register file fd in `File::from_std` by
[@&#8203;NKID00](https://togithub.com/NKID00) in
[https://github.com/bytedance/monoio/pull/277](https://togithub.com/bytedance/monoio/pull/277)
- feat(op, fs): ✨ add `MkDirAt` opcode in io-uring and
`create_dir(_all)` by [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/270](https://togithub.com/bytedance/monoio/pull/270)
- feat: unlink op, remove_file and remove_dir by
[@&#8203;NKID00](https://togithub.com/NKID00) in
[https://github.com/bytedance/monoio/pull/288](https://togithub.com/bytedance/monoio/pull/288)
- feat: support `opcode::RenameAt` by
[@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) in
[https://github.com/bytedance/monoio/pull/289](https://togithub.com/bytedance/monoio/pull/289)

#### New Contributors

- [@&#8203;tshepang](https://togithub.com/tshepang) made their first
contribution in
[https://github.com/bytedance/monoio/pull/258](https://togithub.com/bytedance/monoio/pull/258)
- [@&#8203;liuxin231](https://togithub.com/liuxin231) made their first
contribution in
[https://github.com/bytedance/monoio/pull/262](https://togithub.com/bytedance/monoio/pull/262)
- [@&#8203;hatoo](https://togithub.com/hatoo) made their first
contribution in
[https://github.com/bytedance/monoio/pull/264](https://togithub.com/bytedance/monoio/pull/264)
- [@&#8203;Lzzzzzt](https://togithub.com/Lzzzzzt) made their first
contribution in
[https://github.com/bytedance/monoio/pull/273](https://togithub.com/bytedance/monoio/pull/273)
- [@&#8203;Xuanwo](https://togithub.com/Xuanwo) made their first
contribution in
[https://github.com/bytedance/monoio/pull/279](https://togithub.com/bytedance/monoio/pull/279)
- [@&#8203;SteveLauC](https://togithub.com/SteveLauC) made their first
contribution in
[https://github.com/bytedance/monoio/pull/265](https://togithub.com/bytedance/monoio/pull/265)
- [@&#8203;NKID00](https://togithub.com/NKID00) made their first
contribution in
[https://github.com/bytedance/monoio/pull/277](https://togithub.com/bytedance/monoio/pull/277)

**Full Changelog**:
bytedance/monoio@0.2.3...0.2.4

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/spiraldb/vortex).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet