This repository has been archived by the owner on Feb 21, 2022. It is now read-only.
[bug] fixed sort-imports rule (closes #363) #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 5, 2018 17:29
…s'. Check that it fails (which it does)
… because 'none' evaluates to 0 and 0 is false. The statement should instead check that memberSyntaxTypeMap[t] is actually undefined instead of checking to see if it evaluates to false.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that 'none' option is being skipped when sorting, as the enum evaluates to 0 which is considered false, so it is not added to the sort order. This allows a bug that will falsely say that 'none' must come before 'all' even when 'none' is the first value.