Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment to reflect correct google-auth package version requirement #1503

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Fix comment to reflect correct google-auth package version requirement #1503

merged 1 commit into from
Aug 10, 2024

Conversation

ikmals
Copy link

@ikmals ikmals commented Aug 8, 2024

Changes

  • Updated the comment in gspread/auth.py to indicate that the api_key feature is available starting from google-auth version 2.15.0.

Context

The previous comment incorrectly stated that the api_key feature was available from version 2.4.0. This has been corrected to 2.15.0.

Screenshots

  • v2.14.1:
Screenshot 2024-08-08 at 10 03 06
  • v2.15.0:
Screenshot 2024-08-08 at 10 03 25

alifeee
alifeee approved these changes Aug 8, 2024
View reviewed changes
Copy link
Collaborator

@alifeee alifeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much :)
hopefully we make a release soon which will include this

@lavigne958 lavigne958 merged commit 60bc77f into burnash:master Aug 10, 2024
5 checks passed
@alifeee alifeee mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavigne958 lavigne958 lavigne958 approved these changes

@alifeee alifeee alifeee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikmals @alifeee @lavigne958