nav: set the active item on the top navigation #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bump-content-hub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thimy
reviewed
Jun 25, 2024
src/_components/shared/nav/item.erb
Outdated
| @@ -1,3 +1,3 @@ | |||
| <nav-item> | |||
| <nav-item<% if @active %> class="active"<% end %>> | |||
There was a problem hiding this comment.
What do you think about using the a11y attribute aria-current=true instead?
Based on the three collections “help”, “guides” and “product-updates” this commit adds a CSS property `active` on the active category in the top navigation bar. Visually I've simply added an underlined text decoration (but fill free to suggest something else). Part of bump-sh#193
thimy
force-pushed
the
highlight-current-category-in-nav
branch
from
bd81812 to
1e5dd46
Compare
|
I changed the style of the current page link to match what we have in the guides page, is that alright with you @grossyoan ? |
|
That's perfect Thimy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the three collections “help”, “guides” and “product-updates”
this commit adds a CSS property
activeon the active category in thetop navigation bar.
Visually I've simply added an underlined text decoration (but fill
free to suggest something else).
before
after
Part of #193