Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: add release step in CI to push packed tarballs to GH release #29

Merged
merged 1 commit into from
May 26, 2021

Conversation

paulRbr
Copy link
Member

@paulRbr paulRbr commented May 26, 2021

As part of #18 this is a test to try to push tarballs generated by
oclif to a Github Release.

The idea for the release process would be in two steps:

  1. locally on a developer machine: bump the version, commit, tag and
    publish to npm with the following command:
npm run publish -- 2.0.1

This will not create a github release anymore (due to the added
--no-release-draft tag passed to np).

  1. once the tag is pushed, the CI kicks in with this github action
    by doing the following:
  • Github draft release creation
  • Upload of standalone tarballs (generated by oclif)
  1. The developer needs to edit the newly created draft release to
    write release notes and publish the github release 🚀

@paulRbr paulRbr requested a review from scharrier May 26, 2021 10:19
@paulRbr paulRbr force-pushed the automated-release branch from ffa1c9f to 7064ee1 Compare May 26, 2021 10:56
As part of #18 this is a test to try to push tarballs generated by
oclif to a Github Release.

The idea for the release process would be in two steps:

- locally on a developer machine: bump the version, commit, tag and
  publish to npm with the following command:

  ```
  npm run publish -- 2.0.1
  ```

  This will not create a github release anymore (due to the added
  `--no-release-draft` tag passed to `np`).

- once the tag is pushed, the CI kicks in with this [github action](https://github.com/softprops/action-gh-release)
  by doing the following:
  - Github draft release creation
  - Upload of standalone tarballs (generated by oclif)

- The developer can then edit the newly created draft release to
  write release notes and publish the release 🚀
@paulRbr paulRbr force-pushed the automated-release branch from 7064ee1 to 5e2a566 Compare May 26, 2021 11:18
@Polo2 Polo2 self-requested a review May 26, 2021 14:35
Copy link
Member

@Polo2 Polo2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully we could discuss about this PR IRL, it allows me to approve this PR.
Thanks for your patience 👍

@paulRbr paulRbr merged commit 7e65e86 into bump-sh:main May 26, 2021
@paulRbr paulRbr deleted the automated-release branch June 16, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants