Fixing Standard Ruby #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazayas
commented
Jun 23, 2023
| @@ -4,7 +4,7 @@ | |||
| # the maximum value specified for Puma. Default is set to 5 threads for minimum | |||
| # and maximum; this matches the default thread size of Active Record. | |||
| # | |||
| max_threads_count = ENV.fetch("RAILS_MAX_THREADS") { 5 } | |||
| max_threads_count = ENV.fetch("RAILS_MAX_THREADS", 5) | |||
There was a problem hiding this comment.
I remember this fix or the one below it with PORT 3000 caused me some issues in another project I was working on, so we might need to double check or ignore these lines before merging the PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw #20, and I'm guessing what it means is we want to implement standard Ruby for the tests that are generated when running
flush, etc.In the meantime, this PR addresses the standard Ruby fixes when just running
standardrb --fixagainstmain.