-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add checks for linting, building APK and building web #197
Conversation
I think I still had that old commit somewhere in my git history (probably committed to master at that time). Also, weirdly the workflows are not running, I'll look into it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Saransh-cpp can you remove all the other changes from this PR and just keep the CI, if you feel other things are relevant, you can open another PR. This will make reviewing a lot easier.
On it! |
0607748
to
f7311c5
Compare
I will create another PR to lint all the files, fixing the lint check. |
f7311c5
to
df08ee8
Compare
.github/workflows/checks.yml
Outdated
@@ -0,0 +1,52 @@ | |||
name: Checks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name: Checks | |
name: build-checks |
.github/workflows/checks.yml
Outdated
# everyday at 3 am UTC | ||
schedule: | ||
- cron: '0 3 * * *' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# everyday at 3 am UTC | |
schedule: | |
- cron: '0 3 * * *' |
.github/workflows/checks.yml
Outdated
flutter pub get | ||
flutter analyze | ||
|
||
build-apk-and-web: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's separate out the builds for web and android.
Closing this PR. I am cleaning up my open PRs and closing the stale ones. Please let me know if the changes are required in the future. I would be more than happy to re-open and work on this. |
Changes/Additions
analysis_options.yaml