Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add checks for linting, building APK and building web #197

Closed
wants to merge 2 commits into from

Conversation

Saransh-cpp
Copy link
Contributor

Changes/Additions

  • Added lint instructions in analysis_options.yaml
  • Formatted all the files (to pass the lint check)
  • Added a new workflow to check lint, build apk, and build web

@Saransh-cpp
Copy link
Contributor Author

I think I still had that old commit somewhere in my git history (probably committed to master at that time). Also, weirdly the workflows are not running, I'll look into it.

Copy link
Member

@yashlamba yashlamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Saransh-cpp can you remove all the other changes from this PR and just keep the CI, if you feel other things are relevant, you can open another PR. This will make reviewing a lot easier.

@yashlamba yashlamba linked an issue Jan 15, 2022 that may be closed by this pull request
@Saransh-cpp
Copy link
Contributor Author

On it!

@Saransh-cpp
Copy link
Contributor Author

I will create another PR to lint all the files, fixing the lint check.

@@ -0,0 +1,52 @@
name: Checks
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Checks
name: build-checks

Comment on lines 7 to 10
# everyday at 3 am UTC
schedule:
- cron: '0 3 * * *'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# everyday at 3 am UTC
schedule:
- cron: '0 3 * * *'

flutter pub get
flutter analyze

build-apk-and-web:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's separate out the builds for web and android.

@Saransh-cpp
Copy link
Contributor Author

Closing this PR.

I am cleaning up my open PRs and closing the stale ones. Please let me know if the changes are required in the future. I would be more than happy to re-open and work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Adding basic checks in a new workflow
2 participants