Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Adding basic checks in a new workflow #196

Open
Saransh-cpp opened this issue Jan 12, 2022 · 2 comments
Open

CI: Adding basic checks in a new workflow #196

Saransh-cpp opened this issue Jan 12, 2022 · 2 comments
Labels

Comments

@Saransh-cpp
Copy link
Contributor

The application right now lacks tests, we can add a couple of basic ones -

  • Lint tests (would make sure that no one is using a deprecated API or an older version of Flutter)
  • Making sure the apk builds (would make sure that a PR is not destroying the app completely)

These tests will run on push and on a PR which might make the reviewing process a bit easier. I can take this up if we plan on adding this!

@yashlamba
Copy link
Member

@Saransh-cpp Sounds good! Along with the apk check, you can also add flutter web build check as well (that's what we primarily use)

I'll rename tests -> checks so that we don't confuse them with actual flutter tests later.

@yashlamba yashlamba changed the title Adding basic tests in a new workflow CI: Adding basic check in a new workflow Jan 12, 2022
@yashlamba yashlamba changed the title CI: Adding basic check in a new workflow CI: Adding basic checks in a new workflow Jan 12, 2022
@Saransh-cpp
Copy link
Contributor Author

Great!

@yashlamba yashlamba linked a pull request Jan 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants