Feat#38/change material-ui version to mui 5 #41
Conversation
| import CssBaseline from '@material-ui/core/CssBaseline'; | ||
| import { ThemeProvider } from '@material-ui/core/styles'; | ||
| import CssBaseline from '@mui/material/CssBaseline'; | ||
| import { ThemeProvider, StyledEngineProvider } from '@mui/material/styles'; |
There was a problem hiding this comment.
Why do we need StyledEngineProvider?
There was a problem hiding this comment.
It gives custom styles precedence over MUI
src/layout/TopBar/TopBar.js
Outdated
| label="Organization" | ||
| select | ||
| > | ||
| <MenuItem> |
There was a problem hiding this comment.
Why is only None option hard coded here for Super Admin?
There was a problem hiding this comment.
Because we don't have any api to fetch all org names
There was a problem hiding this comment.
There should be an API that we already use in TP as well as Insights code. So it should be similar here as well.
There was a problem hiding this comment.
I tried and it was throwing 404 confirmed with BE as well that there's no API in buildly.io to fetch all orgs
There was a problem hiding this comment.
If we want a global admin filter we need to have a list of organizations. Without it, you cannot create a dropdown for global admin.
src/layout/TopBar/TopBar.js
Outdated
| </IconButton> | ||
| </Link> | ||
| <IconButton aria-label="logout" color="inherit" onClick={handleLogoutClick}> | ||
| {isSuperAdmin && ( |
There was a problem hiding this comment.
Check the placement as well. It is all disturbed.
There was a problem hiding this comment.
Radhika can you tell me screen resolution, for me all medium and large screens placement is proper
| @@ -1,17 +1,22 @@ | |||
| /* eslint-disable import/no-named-as-default-member */ | |||
There was a problem hiding this comment.
Please remove these ignore and resolve the issues in the file.
There was a problem hiding this comment.
Tried resolving some are still throwing errors after trying the solution mentioned in the documentation
| @@ -1,19 +1,28 @@ | |||
| /* eslint-disable import/no-named-as-default-member */ | |||
There was a problem hiding this comment.
Remove these ignores and fix the file issues.
There was a problem hiding this comment.
Tried resolving some are still throwing errors after trying the solution mentioned in the documentation
MounikaReddy15
changed the title
Purpose
change material-ui version to mui 5
Ticket number
#38