-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone Screen - Complete Management #68
base: master
Are you sure you want to change the base?
Conversation
…t/buildly-react-template into feat#39/milestones-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- On edit, allow users to edit name of the milestone
- If you can give select all option that can be useful
- I found one bug if I delete any milestone it deletes all milestones in the given repos. Example: There were milestones for december but now none of this is seen. All for the same duration are deleted (This is little confusing since you have delete besides each record and edit is happening for selected record only)
@SiddharthBhansali13 Works fine.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of issues that I noticed.
-
When I add a new sprint it does create it in the GitHub repos but the milestones drop-down on the page does not have the new added sprint as an option. If I refresh it, then it comes as an option in the milestones drop-down.
-
Once the milestone is/are closed, the selection still stays as is whereas it should be un-selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested changes done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API calls/redux not working as expected. Requested changes
Original developer not available, merge and fix in main.
@IvyMMutiso and @odenypeter, I assume since we are moving to the new release front end we don't need this branch anymore? |
Purpose
To manage milestones of a given GitHub org's repositories.
Further info
URL:
/app/milestone
Need to add 2 key-value pairs in .env.development.local:
GITHUB_TOKEN: "{add_github_token_here}", GITHUB_API_URL: "https://api.github.com", GITHUB_OWNER: {add_your_owner_name}
Ticket number
#39