Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone Screen - Complete Management #68

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

SiddharthBhansali13
Copy link

@SiddharthBhansali13 SiddharthBhansali13 commented Feb 2, 2022

Purpose

To manage milestones of a given GitHub org's repositories.

Further info

URL: /app/milestone
Need to add 2 key-value pairs in .env.development.local:
GITHUB_TOKEN: "{add_github_token_here}", GITHUB_API_URL: "https://api.github.com", GITHUB_OWNER: {add_your_owner_name}

Ticket number

#39

@SiddharthBhansali13 SiddharthBhansali13 added the enhancement New feature or request label Feb 2, 2022
@SiddharthBhansali13 SiddharthBhansali13 added this to the Sprint-31-Jan milestone Feb 2, 2022
@SiddharthBhansali13 SiddharthBhansali13 self-assigned this Feb 2, 2022
@SiddharthBhansali13 SiddharthBhansali13 linked an issue Feb 2, 2022 that may be closed by this pull request
5 tasks
src/modules/http/http.service.js Outdated Show resolved Hide resolved
src/pages/Milestone/Milestone.js Show resolved Hide resolved
Copy link

@yasmin2496 yasmin2496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. On edit, allow users to edit name of the milestone
  2. If you can give select all option that can be useful
  3. I found one bug if I delete any milestone it deletes all milestones in the given repos. Example: There were milestones for december but now none of this is seen. All for the same duration are deleted (This is little confusing since you have delete besides each record and edit is happening for selected record only)

@yasmin2496
Copy link

yasmin2496 commented Mar 22, 2022

@SiddharthBhansali13 Works fine.

  1. Can you add a feature to allow multi-selection on milestones so that it is easy to close milestones in bulk
  2. For the repositories and milestones that are selected, can a cross icon be added there that allows user to deselect the repo or milestones
  3. Allow user to edit Owner from UI if needed and fetch default value from environment

Copy link

@RadhikaPPatel RadhikaPPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of issues that I noticed.

  • When I add a new sprint it does create it in the GitHub repos but the milestones drop-down on the page does not have the new added sprint as an option. If I refresh it, then it comes as an option in the milestones drop-down.

  • Once the milestone is/are closed, the selection still stays as is whereas it should be un-selected.
    image

  • The screen is overflowing. So please handle this.
    image

Copy link

@yasmin2496 yasmin2496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes done

Copy link

@RadhikaPPatel RadhikaPPatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API calls/redux not working as expected. Requested changes

@glind glind dismissed RadhikaPPatel’s stale review September 30, 2022 14:02

Original developer not available, merge and fix in main.

@glind
Copy link

glind commented Apr 26, 2023

@IvyMMutiso and @odenypeter, I assume since we are moving to the new release front end we don't need this branch anymore?

@glind glind removed this from the Sprint-31-Jan milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Milestones page - FE
6 participants