Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render platform overrides in the UI #8026

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Render platform overrides in the UI #8026

merged 2 commits into from
Dec 16, 2024

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented Dec 6, 2024

Render platform property overrides that are set with --remote_header=x-buildbuddy-platform.NAME=VALUE. Also redact these before caching.

image

Copy link
Contributor

@vanja-p vanja-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but don't trust me on Typescript reviews.

app/invocation/invocation_action_card.tsx Outdated Show resolved Hide resolved
@bduffany bduffany force-pushed the header-overrides-ui branch 3 times, most recently from cc1c38e to 9e3cc0e Compare December 10, 2024 17:17
@bduffany bduffany requested a review from jdhollen December 10, 2024 18:41
@bduffany bduffany force-pushed the header-overrides-ui branch from 9e3cc0e to ee33f5c Compare December 13, 2024 22:27
@bduffany bduffany merged commit 78acf99 into master Dec 16, 2024
15 checks passed
@bduffany bduffany deleted the header-overrides-ui branch December 16, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants