Fix for some problems in overlay: black screen, video freezes, DAT files, ...

[lmerckx]

Some games (cobra, roadblaster, astron, bega) don't work with last revision for two reasons:

1. The CPU's MAX_CONTEXT_SIZE is too short and must be increased. Error returned by Hypseus.
2. The default overlay transparent color is 0 (black) and Hypseus doesn't support other color requested by specific games

The corrections made in this branch seem to resolve these problems.

[lmerckx]

Two other problems encountered in some games:

1. Some games (bega, astron, ...) freezes during some seconds and restart after a timeout message VLDP error! Timed out waiting for internal thread to accept command!:
   This problems seems due to the "lock" system between methods vid_blit and vid_update_yuv_overlay.
   Indeed, these methods use SDL_CondWait and SDL_CondSignal to avoid conflict when changing same texture.
   But for these games, vid_update_yuv_overlay is called twice (setting vid_update_yuv_overlay to true) without any call to vid_blit.
   It leads in a blocking call to vid_update_yuv_overlay, which also blocks the command handler; and avoid processing other command.
   Only the timeout, after about 7 seconds, unblocks the emulator.
   So, I replace SDL_CondWait by SDL_CondWaitTimeout (with a timeout of 100 ms) to solve the problem.

2. Videos of Dragon's Lair 2 block after some frames:
   After some analysis, it seems that vid_blit is never called for this game during the video play !
   It seems due to this line of code:
   if (m_game_uses_video_overlay && m_video_overlay_needs_update) blit();
   where m_video_overlay_needs_update is never true.
   The correction was to set this flag to true when receiving an IRQ 0.

These modifications solve these problems but I'm not sure it was the best way to do it.
So, I'm opened to any other solutions !

By the way, the solution for 1 also solves the problem of generation of .DAT files.

[lmerckx]

This PR should be linked to issues:

• Video index rebuild fails to complete #22: Video index rebuild fails to complete
• Playback errors and stalling #21: Playback errors and stalling

And perhaps:
#13: debian 9 strech

[ghost]

@lmerckx can you send a pull request to https://github.com/grant2258/hypseus I will test later on today when i get time if you like.

[lmerckx]

@grant2258 It seems you already merge changes. I see my commits in your history.
Still need to do it ?

[ghost]

it sok i found them still not tested yet need to remember the command line to start the game has been a while :)

[ghost]

still getting some video freeinzing no where as bad as it used to be though in dragons lair 2

[ghost]

./daphne.bin lair2 vldp -framefile /home/pi/RetroPie/roms/daphne/lair.daphne/lair.txt -useoverlaysb 2

(am testing on retropie)

[lmerckx]

@grant2258 I don't know if it is linked to your problem but since GCC 7, I needed to remove the embedded version of libmpeg2 and use the standard one.
Performance are not impacted !

See my patch for Recalbox: https://gitlab.com/recalbox/recalbox/blob/master/package/hypseus/hypseus-005-stdmpeg2.patch

[vanfanel]

@lmerckx Do you know what happened to updated Hypseus code? This repository doesn't look like merging your fixes. I did the overlay stuff years ago and I would love having your changes incorporated to Hypseus... But the main repo looks SO abandoned.

[lmerckx]

@vanfanel Hello vanfanel.
I don't know why these changes are not merged. They work and they are used in Recalbox without problem for some years.
It seems that this project is not yet maintained anymore. It is sad because it was a very good idea and there is still work to do !

[lmerckx]

Just ignore my previous comment, so. :)
Thank you for the merge.

[h0tw1r3]

Clearly I haven't had much time for my personal projects such as this one.
Appreciate the nudge.
I'm always hesitant to merge without testing the build myself. Going forward I'll merge things that make sense, or have a second comment "works for me".

[vanfanel]

@lmerckx
Are there any other Recalbox-exclusive patches not yet merged?

What OS are you using?
Have you tried -fullscreen? I am seeing some "stroboscopic effects" around the video if I do.

@h0tw1r3 Thanks for the merges! It's nice to see this move again!

[lmerckx]

@vanfanel All patches can be found here: https://gitlab.com/recalbox/recalbox/-/tree/master/package/hypseus
Most of them are specific to Recalbox.

Recalbox works on Buildroot (Linux distribution) for Raspberry PI, PC and Odroid.
It works fine on Raspberry but some people report me flashes on Odroid and sometimes PC (depending on the graphic card).
I haven't investigated yet.

[vanfanel]

@lmerckx I have just done a PR that fixes the flahsing, in #31

Please propagate this to RecalBox, etc if you are into them.