Refactor Product recalculate_count_on_hand method

bsylvain · Jan 19, 2012 · 5984f7e · 5984f7e
1 parent 90f6d51
commit 5984f7e
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/core/app/models/spree/product.rb b/core/app/models/spree/product.rb
@@ -180,8 +180,7 @@ def self.like_any(fields, values)
     private
       def recalculate_count_on_hand
         product_count_on_hand = has_variants? ?
-          variants.inject(0) { |acc, v| acc + v.count_on_hand } :
-          (master ? master.count_on_hand : 0)
+          variants.sum(:count_on_hand) : (master ? master.count_on_hand : 0)
         self.count_on_hand = product_count_on_hand
       end