Fix AdjustmentsHelper#display_line_item showing empty brackets if a v…

…ariant had no options text
bsylvain · Oct 21, 2013 · 1790d0d · 1790d0d
1 parent 28c7ba3
commit 1790d0d
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/backend/app/helpers/spree/admin/adjustments_helper.rb b/backend/app/helpers/spree/admin/adjustments_helper.rb
@@ -36,7 +36,11 @@ def display_adjustable(adjustable)
 
       def display_line_item(line_item)
         variant = line_item.variant
-        "#{variant.product.name} <br>(#{variant.options_text})<br>#{line_item.display_total}".html_safe
+        parts = []
+        parts << variant.product.name
+        parts << "(#{variant.options_text})" if variant.options_text.present?
+        parts << line_item.display_total
+        parts.join("<br>").html_safe
       end
 
       def display_shipment(shipment)