Use isinstance instead of boolean checks #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
request.requiresOnlineAPIAccess()
, it's better to doisinstance(request, OnlineRoutineRequest)
for three reasons:request
will have the attributes thatOnlineRoutineRequest
s should have, e.g.getCredentials()
.isinstance
checks tell Mypy that the type of that variable, allowing the code to typecheck successfully.This PR is based on #31, #32, #34, and #35.