Allow an additional image caption (PR #269 followup) #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance to have this PR reviewed and merged? The original PR has already been agreed to be merged, it was just about the merge conflicts resolution which is done here |
maxim-kukushkin
changed the title
|
@brutaldesign, any thoughts about the PR? :) |
…tion divs (to support backward compatibility with the previous code which allowed HTML tags)
|
@brutaldesign, in the original PR you indicated that this change is fine to merge (#269 (comment), yeah, it was 6 years ago). Any chance it can be merged now? This PR addresses your point to base the changes on the latest code version |
|
@brutaldesign, are you still maintaining the repo, or is it abandoned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of the previously raised PR. That one was agreed to be merged, but had merge conflicts and seems like the author of the PR has stopped maintaining it.
The original description was:
"The attribute for title and caption are now configurable via the option array. A caption is usful to give an additional image description or provide proper attribution. This includes the XSS fix from #268"
I like the idea of having an ability to add an optional comment to the photo, as for example in my gallery I'm storing comments in JPEG's tags. They can be multi-line and are not necessarily suitable for the main title. In the original version, the title doesn't support multiple lines allowing the text to overflow.
JS is not my specialty, I just replicated the original changes, so happy to incorporate corrections/suggestions if any