style(shibboleth-sp): fix linting errors in role defaults

Signed-off-by: Bruce Becker <[email protected]>

roles/shibboleth-sp/defaults/main.yml

@@ -2,42 +2,42 @@
 # Set to yes/true to generate self-signed SSL certificate for signing requests/
 # response received from/sent to the IdP, as well as for receiving encrypted
 # responses.
-shibboleth_sp_ssl_cert_generate: no
+shibboleth_sp_ssl_cert_generate: false
 
 # SSL certificate subject (ignored when shibboleth_sp_ssl_cert_generate is set
 # to no)
-#shibboleth_sp_ssl_cert_subj: "/C=/ST=/L=/O=/CN=sp.example.org"
+# shibboleth_sp_ssl_cert_subj: "/C=/ST=/L=/O=/CN=sp.example.org"
 
 # SSL certificate (ignored when shibboleth_sp_ssl_cert_generate is set to yes)
-#shibboleth_sp_ssl_cert: |
-#  -----BEGIN CERTIFICATE-----
-#  ...
-#  -----END CERTIFICATE-----
+# shibboleth_sp_ssl_cert: |
+#   -----BEGIN CERTIFICATE-----
+#   ...
+#   -----END CERTIFICATE-----
 
 # SSL certificate key (ignored when shibboleth_sp_ssl_cert_generate is set to
 # yes)
-#shibboleth_sp_ssl_cert_key: |
-#  -----BEGIN PRIVATE KEY-----
-#  ...
-#  -----END PRIVATE KEY-----
+# shibboleth_sp_ssl_cert_key: |
+#   -----BEGIN PRIVATE KEY-----
+#   ...
+#   -----END PRIVATE KEY-----
 
 # ApplicationDefaults
 # The SAML entityID of this SP
-shibboleth_sp_entity_id: "https://sp.example.org/shibboleth"
+shibboleth_sp_entity_id: https://sp.example.org/shibboleth
 # One or more attributes used for the primary identifier of the browser user
 # passed through the REMOTE_USER server variable.
-# Set to null to disable setting the variable. 
-shibboleth_sp_remote_user: "eppn persistent-id targeted-id"
+# Set to null to disable setting the variable.
+shibboleth_sp_remote_user: eppn persistent-id targeted-id
 # Where the SP redirects the client to when there is nothing else that can be
 # done with a request and can be set to a standard home page or index page.
-#shibboleth_sp_home_url: "/"
+# shibboleth_sp_home_url: "/"
 
 shibboleth_sp_session:
   # The base location on the server that dispatches requests to the handlers
   # configured inside the <Sessions> element. The location is specified as a
   # relative or absolute URL. The default is "/Shibboleth.sso" on v2.4+,
   # required otherwise.
-#  handler_url: "/Shibboleth.sso"
+  #  handler_url: "/Shibboleth.sso"
   # When handlerSSL is set to true, only web requests over SSL/TLS will be
   # processed by handlers. Other requests may be blocked, or possibly ignored
   # (and usually result in a 404 error) depending on the web server, but will
@@ -62,7 +62,7 @@ shibboleth_sp_session:
   # this limits the amount of time between the act of authentication and the
   # attempt to access the SP. This can be useful to ensure that the SAML 2.0
   # ForceAuthn flag was honored.
-#  max_time_since_authn:
+  #  max_time_since_authn:
   # The IdP will place the IP address of the user agent it authenticated into
   # the assertions it issues. When true, the SP will check this address
   # against the address of the client presenting an assertion before creating
@@ -75,21 +75,21 @@ shibboleth_sp_session:
   # associated with this session come from the same address. This can help
   # protect against cookie theft and is less likely than the checkAddress
   # setting to block legitimate access. Default is true.
-#  consistent_address: "true"
+  #  consistent_address: "true"
   # Meta-properties like path or the secure and HttpOnly flags to attach to
   # the cookies. Defautls to "; path=/; HttpOnly". If set to a custom string,
   # the string is appended to the cookie values maintained by the SP. A common
   # value for SSL-only use is "; path=/; secure; HttpOnly". As of v2.5, this
   # property can be set to a pair of built-in values, "http" and "https",
   # which expand to the default and SSL-only properties respectively.
-  cookie_props: "http"
+  cookie_props: http
   # Cookie lifetime in seconds. If set, cookies used for session management
   # will be created with the designated lifetime. When omitted, which is the
   # default, such cookies are in-memory only and do not persist across browser
   # restarts (assuming various session restore features aren't in use). Note
   # that this will not affect "transitory" cookies used for maintaining state
   # across redirects.
-#  cookie_lifetime:
+  #  cookie_lifetime:
   # Controls how information associated with requests for authentication,
   # primarily the original resource accessed, is preserved for the completion
   # of the authentication process. If not specified, the resource URL is
@@ -100,7 +100,7 @@ shibboleth_sp_session:
   # <StorageService> element, typically "ss:mem". As of v2.5, the "cookie"
   # option can include a ":n" suffix, where n specifies the number of cookies
   # to permit before purging old ones, defaulting to 25.
-  relay_state: "ss:mem"
+  relay_state: ss:mem
   # V3.2+: One of "none", "exact", "host", "allow", "exact+allow", "host+allow"
   # Earlier: One of "none", "exact", "host", "whitelist", "exact+whitelist",
   # "host+whitelist".
@@ -112,48 +112,48 @@ shibboleth_sp_session:
 # SSO settings. To allow for >1 IdP, remove entity_id property and adjust
 # discovery_url to point to discovery service.
 shibboleth_sp_sso:
-  protocols: "SAML2 SAML1"
-  entity_id: "https://idp.example.org/idp/shibboleth"
-  discovery_protocol: "SAMLDS"
-  discovery_url: "https://ds.example.org/DS/WAYF"
+  protocols: SAML2 SAML1
+  entity_id: https://idp.example.org/idp/shibboleth
+  discovery_protocol: SAMLDS
+  discovery_url: https://ds.example.org/DS/WAYF
 
 shibboleth_sp_logout:
-  protocols: "SAML2 Local"
+  protocols: SAML2 Local
 
 # See https://wiki.shibboleth.net/confluence/display/SP3/Handler
 shibboleth_sp_handlers:
-  - type: "MetadataGenerator"
-    location: "/Metadata"
+  - type: MetadataGenerator
+    location: /Metadata
     signing: "false"
-  - type: "Status"
-    location: "/Status"
-    acl: "127.0.0.1 ::1"
-  - type: "Session"
-    location: "/Session"
+  - type: Status
+    location: /Status
+    acl: 127.0.0.1 ::1
+  - type: Session
+    location: /Session
     show_attributes: "false"
-  - type: "DiscoveryFeed"
-    location: "/DiscoFeed"
+  - type: DiscoveryFeed
+    location: /DiscoFeed
 
-shibboleth_sp_supportcontact_email: "root@localhost"
+shibboleth_sp_supportcontact_email: root@localhost
 
 # TODO Add support for metadata filters
 shibboleth_sp_metadata_providers: []
 #  - type: "XML"
 #    uri: "http://federation.org/federation-metadata.xml"
 #    backing_file_path: "federation-metadata.xml"
 #    reload_interval: 7200
-#  - type: "XML" 
+#  - type: "XML"
 #    file: "partner-metadata.xml"
 
 shibboleth_sp_attribute_extractors:
-  - type: "XML"
+  - type: XML
     params:
       validate: "true"
       reloadChanges: "false"
-      path: "attribute-map.xml"
+      path: attribute-map.xml
 
 shibboleth_sp_attribute_resolvers:
-  - type: "Query"
+  - type: Query
     subject_match: "true"
 
 # The default settings can be overridden by creating ApplicationOverride
@@ -188,14 +188,14 @@ shibboleth_sp_overrides: []
 #        name: "Local"
 #      handlers:
 #        - handler:
-#          type: "MetadataGenerator" 
+#          type: "MetadataGenerator"
 #          location: "/Metadata"
 #          signing: "false"
 #        - handler:
 #          type: "Status"
 #          location: "/Status"
 #          acl: "127.0.0.1 ::1"
-#        - handler: 
+#        - handler:
 #          type: "Session"
 #          location: "/Session"
 #          show_attributes: "true"
@@ -211,7 +211,7 @@ shibboleth_sp_ext_libraries: []
 #    fatal: "false"
 
 # Path to file containing attribute mappings
-shibboleth_sp_attribute_map_file: "attribute-map.xml"
+shibboleth_sp_attribute_map_file: attribute-map.xml
 
 # Path to file containing attribute policies
-shibboleth_sp_attribute_policy_file: "attribute-policy.xml"
+shibboleth_sp_attribute_policy_file: attribute-policy.xml