Drop support for PHP < 8.1, upgrade to PHPUnit 10 #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimmi20
reviewed
Nov 21, 2023
Slamdunk
force-pushed
the
drop_old_php
branch
from
0025f48 to
17dc055
Compare
|
Hi, since #640 has been merged, you should as well update the list of |
mimmi20
approved these changes
Nov 21, 2023
This was because you dropped the OS from the matrix in this PR, not relevant to #640 - anyway I've updated it to work for the new job names. Not sure why I can't just ask for "green builds" and have to specify each job but hey. We can fix that later :) |
asgrim
approved these changes
Nov 21, 2023
|
Yeah sorry, wrong link, I meant after 85485dc Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by #640
ubuntu-latest; remove it from matrix to get a cleaner GH status nameBuild green on my fork:
https://github.com/Slamdunk/browscap-php/actions/runs/6941992974