-
Notifications
You must be signed in to change notification settings - Fork 83
Schema/update #178
base: master
Are you sure you want to change the base?
Schema/update #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Basically context is a duplicate of Object
use in the object Object
. This is use to pass additinal data as the context. (usefull in flowdock case to track the thread). Check https://www.w3.org/TR/activitystreams-vocabulary/#dfn-context
@@ -5,9 +5,9 @@ | |||
"embedded/group", | |||
"embedded/tag", | |||
"object/collection", | |||
"object/context", | |||
"object/media", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
object need also to be in the list ;)
@@ -34,4 +34,6 @@ properties: | |||
required: [ type, id, url ] | |||
- $ref: "http://schemas.broid.ai/object/place.json" | |||
required: [ type, id, latitude, longitude ] | |||
- $ref: "http://schemas.broid.ai/object/collection.json" | |||
required: [ type, items ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
@@ -4,8 +4,8 @@ | |||
- embedded/group | |||
- embedded/tag | |||
- object/collection | |||
- object/context | |||
- object/media |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- object/context, need to be here also
@killix thanks! Reverted the object/object back with
to fit the doc. Is that correct? Note for later: As |
Forgot the attachements. ✋ Will add that 🕐 |
🤖 🤖, small PR on schemas!
js-beautify
to have readable outputobject.json
looks more like acontext.json
according to the docs. "Object" in the documentation is more the base object of all the Objects, or a generic type for Context and Tags, right? Moved theobject.json
incontext.json
Collections
: moved to onlyMedia
items in activity for now, discussed with @killixObject
enum in tag.id
in context.What do you think?