Change response payload to return rows #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great change, @sollabeck ! I will use this branch in my hybrid app until this gets merged into the next plugin release hopefully. This allows my code to expect the same websql callback response in my browser that does not use the cordova plugin and in my iOS and Android apps that uses this cordova plugin. |
|
works like a charm! |
|
Thanks @sollabeck, this would definitely be a nice enhancement. I will probably reimplement your idea in CoffeeScript in a way so that the user can both get array access and continue to use the "standard" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm expecting all the rows of the response to return in the success callback. This PR returns the rows as part of the response