Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DC-962]Send email to Research Users after they request snapshot access #310

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rjohanek
Copy link

@rjohanek rjohanek commented Aug 30, 2024

Note: pausing on this work until duos integration with data exploration is figured out

Jira: DC-962

What:

  1. Adds a notification for when a snapshot request submitted on terra through the cohort builder.
  2. Updates readme.

Why:

So researcher users will receive an email with information about their request upon submission.

How:

Testing: The dependency on workbenchLibs was tested locally by using sbt publishLocal in workbench-notifications in workbenchLibs and then using the locally published snapshot version in thurloe.

Next: Once the workbench-libs and terra-helmfile PRs are merged, I can update the version of workbench-libs used here in thurloe, and then merge this change up and test the notification support in dev.

See also

https://github.com/broadinstitute/terra-helmfile/pull/5849
broadinstitute/workbench-libs#1701


  • Submitter: Make sure Swagger is updated if API changes
  • Submitter: If updating admin endpoints, also update firecloud-admin-cli
  • Submitter: Update FISMA documentation if changes to:
    • Authentication
    • Authorization
    • Encryption
    • Audit trails
  • Submitter: If you're adding new libraries, sign us up to security updates for them

Copy link

@s-rubenstein s-rubenstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants