Fixing up tests in MarkDuplicates so that tests with duplex UMIs are …

…handled properly (#1404) * Fixing up tests in MarkDuplicates so that tests with duplex UMIs are handled properly.
broadinstitute · Sep 30, 2019 · ab140e2 · ab140e2
1 parent 34d7285
commit ab140e2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/test/java/picard/sam/markduplicates/MarkDuplicateWithMissingBarcodeTest.java b/src/test/java/picard/sam/markduplicates/MarkDuplicateWithMissingBarcodeTest.java
@@ -19,13 +19,22 @@ private class MarkDuplicatesWithMissingBarcodesTester extends MarkDuplicatesTest
         @Override
         public void runTest() {
             boolean hasRX = false;
+            boolean isDuplex = false;
             for (final String argument : this.getArgs()) {
                 if (argument.startsWith(getArgumentName())) {
                     hasRX = true;
                     break;
                 }
+                if (argument.startsWith("DUPLEX_UMI")) {
+                    isDuplex = true;
+                    break;
+                }
+            }
+
+            // Tests that specify the RX tag, or the DUPLEX_UMI argument should not be used with missing barcodes.
+            if (!hasRX && !isDuplex) {
+                addArg(getArgumentName() + "=" + getTagValue());
             }
-            if (!hasRX) addArg(getArgumentName() + "=" + getTagValue());
 
             super.runTest();
         }

diff --git a/src/test/java/picard/sam/markduplicates/MarkDuplicatesTest.java b/src/test/java/picard/sam/markduplicates/MarkDuplicatesTest.java
@@ -311,7 +311,7 @@ public void testWithIndividualReadBarcodes() {
     }
 
     @DataProvider(name = "testDuplexUmiDataProvider")
-    private Object[][] testDuplexUmiDataProvider() {
+    public Object[][] testDuplexUmiDataProvider() {
         return new Object[][]{
                 {
                         // Test case where UMIs are not duplex, but are the same.
@@ -358,7 +358,7 @@ private Object[][] testDuplexUmiDataProvider() {
         };
     }
 
-    @Test(dataProvider = "testDuplexUmiDataProvider",enabled = false)
+    @Test(dataProvider = "testDuplexUmiDataProvider")
     public void testWithUMIs(final boolean duplexUmi, final List<String> UMIs, final List<Integer> alignmentStart1,
                              final List<Integer> alignmentStart2, final List<Boolean> isDuplicate,
                              final List<Boolean> isFirstNegativeStrand, final List<Boolean> isSecondNegativeStrand) {