Script to compute combined FAF of v4 genomes and exomes #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to jg/combined_faf # Conflicts: # gnomad_qc/v4/resources/annotations.py
klaricch
reviewed
Sep 25, 2023
klaricch
reviewed
Sep 25, 2023
…to jg/combined_faf
…nomad_qc into qh/combined_faf
There was a problem hiding this comment.
I've reviewed this one first -- it's possible some things are address in @KoalaQin 's but since thats merging into this branch, I only see some diffs. I'll review that one next.
Script to compute combined FAF of v4 genomes and exomes
…to jg/combined_faf
…to jg/combined_faf
…to jg/combined_faf # Conflicts: # gnomad_qc/v4/resources/annotations.py
Add code for creating the final combined FAF release HT
| ht = ht.annotate( | ||
| joint_freq=freq, | ||
| joint_faf=faf, | ||
| joint_fafmax=gen_anc_faf_max_expr( |
There was a problem hiding this comment.
General question -- maybe for @ch-kr , should this be put on the release? I know you were looking into this a bit more so curious what your thoughts are.
There was a problem hiding this comment.
from chatting with Anne, the FAFs that are actually used by analysts are the values included in this struct (=values that correspond to FAFs from gen anc group with highest FAF for variant, not FAFs from gen anc group with highest AF group for variant); see #477 (comment)
Co-authored-by: Mike Wilson <[email protected]>
Co-authored-by: Mike Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.