Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python version 3.8 -> 3.11 #396

Merged
merged 5 commits into from
Aug 17, 2023
Merged

Conversation

jkgoodrich
Copy link
Contributor

Suggested for Hail

Also added gnomad as a known third party to keep isort from changing the spacing

Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some minor comments asking if we want to update tool versions, but LGTM!

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ch-kr ch-kr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one non-urgent question for the future, but LGTM!

also noting that I only quickly looked over the files reformatted by black

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a general question for the future, should we exclude v2 code from checks? we aren't actively using it, so we shouldn't continually have to maintain it. what are your thoughts? this also came up in this PR (broadinstitute/gnomad_methods#576); v2 still uses the deprecated hl.cond

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we do for some of them that require more than just a quick run to reformat ex: pydocstyle --match-dir='(?!v2|cuKING).*' gnomad_qc
I was going to tell @KoalaQin at the meeting today that we don't need to go back and update hl.cond in past versions

@jkgoodrich jkgoodrich merged commit 991b237 into main Aug 17, 2023
1 check passed
@jkgoodrich jkgoodrich deleted the jg/update_python_version branch August 17, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants