-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update VRS annotation batch script for v4 exomes #382
Conversation
@klaricch I changed the code, to add a |
@klaricch annotations.py is identical to main now, I couldn't merge main into this branch because it's been there too long. |
@klaricch I made changes to get rid of vrs-io-finals, but you can't test with
|
Co-authored-by: klaricch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There are a few changes implemented to make the run:
retry
ininit_job_with_gcloud
to avoid Hail Batch transient errors, suggested by Dan King;bgzip
in--run-vrs
step soimport_vcf
could be run faster;5. moveimport_vcf
to--annotate-original
step because this is faster to run in Query-on-Spark (QoS);6. remove checkpoint since we know where the final folder of the VRS annotationsdelete_temps
because files got removed even if the jobs weren't all successful;exclude duplicate
so it applies to only one input file;gnomad-tmp-4day
inworking-bucket
, so the intermediate files can be automatically deleted);10. Clarify in the docstring that the script has to be run once on QoB, once on QoS.update 2023-08-16:
test
argument to test on 200 partitions;annotate-original
back to original design, now withhailctl batch submit
we can run bothrun-vrs
andannotate-original
in one go