Do not shadow Host header when proxying

Enable usage of Proxrox with hosts and configurations such as Heroku which dispatch based on the `Host` header.
bripkens · Jan 17, 2016 · a3081ef · a3081ef
1 parent 80fa723
commit a3081ef
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 # Changelog
 
+## 1.12.0
+ - Enable usage of Proxrox with Heroku and many other hosters which dispatch based on the `Host` header.
+
 ## 1.11.0
  - All dependencies have been updated to their latest version.
 

diff --git a/lib/config_template.ejs b/lib/config_template.ejs
@@ -63,14 +63,12 @@ http {
     location @proxy {
       proxy_pass             <%- proxy['/'] %>;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 <% } Object.keys(proxy).filter(function(url) { return url !== '/' || root === false; }).forEach(function(url) { %>
     location <%- url %> {
       proxy_pass             <%- proxy[url] %>;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 <% }); Object.keys(websocketProxy).forEach(function(url) { %>

diff --git a/test/expectedConfigs/proxies.conf b/test/expectedConfigs/proxies.conf
@@ -40,14 +40,12 @@ http {
     location @proxy {
       proxy_pass             http://127.0.0.1:8080;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 
     location /api {
       proxy_pass             http://api.example.com;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 

diff --git a/test/expectedConfigs/proxies_without_static_asset_serving.conf b/test/expectedConfigs/proxies_without_static_asset_serving.conf
@@ -34,21 +34,18 @@ http {
     location / {
       proxy_pass             http://127.0.0.1:3000;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 
     location /cms {
       proxy_pass             http://127.0.0.1:8080;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 
     location /api {
       proxy_pass             http://api.example.com;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 

diff --git a/test/expectedConfigs/proxies_without_try_files.conf b/test/expectedConfigs/proxies_without_try_files.conf
@@ -40,14 +40,12 @@ http {
     location /cms {
       proxy_pass             http://127.0.0.1:8080;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 
     location /api {
       proxy_pass             http://api.example.com;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }
 

diff --git a/test/expectedConfigs/proxy.conf b/test/expectedConfigs/proxy.conf
@@ -40,7 +40,6 @@ http {
     location @proxy {
       proxy_pass             http://127.0.0.1:8080;
       proxy_set_header       X-Real-IP $remote_addr;
-      proxy_set_header       Host $host;
       proxy_set_header       X-Forwarded-For $proxy_add_x_forwarded_for;
     }