feat: config.shield.dev
#111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense!
👍 |
brillout
reviewed
Jun 27, 2024
|
Should be good now |
|
Released in Neat idea and nice contribution! Other PRs welcome 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the last months I've ran into a handful more bugs in my project that were basically caused by me not finding them in local development because telefunc does not apply shields in local dev. Thats why I want to enable shields in dev to not have ugly surprises in prod. This addresses #78 which was my underlying issue to propose #81
I understand that the shield generation takes some time but after testing it in my project on my machine it was not really noticeable, and I gladly eat that caveat if it becomes more noticeable as the project grows.
Next thing I would do if you are cool with the approach is to add it to the docs.