Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore refactor schema loader #55

Merged
merged 27 commits into from
Mar 2, 2020
Merged

Chore refactor schema loader #55

merged 27 commits into from
Mar 2, 2020

Conversation

loganripplinger
Copy link
Contributor

@loganripplinger loganripplinger commented Mar 2, 2020 •
edited
Loading

  • Adds a set of Descriptor classes.
  • A DescriptorGetter class allows DMM/DRM to load both a list of directories and a list of descriptor dictionaries.
  • Descriptor helper classes act as interfaces that encompass the relevant handling of the data type
  • Dependency inject sqlalchemy base to enable testing
  • Loads only json files - Data Resource Manager crashes when non-JSON file is encountered #44
  • Add logging to conftest.
  • Fixes DRM error.

Logan added 27 commits February 25, 2020 19:52
Fix alembic logger hijacking bug.
72e8260
Add descriptor storage to db. DMM on start loads descriptors from DB …
7d030f3 
…first.
Remove test depenency on schemas being present in local dir.
adc1137
Add unit tests for new helper functions.
027cd8d
Refactor DMM and DRM to use Descriptor helper class.
04431b8
Add descriptor file helpers and test skeleton.
27af902
Refactor descriptor loaders to use object. Not working 100%.
5442a47
First version of descriptor iterator.
37bdad7
Merge master.
8031d6b
Merge master.
2174140
WIP: Run DMM on docker successfully. Tests failing.
136355c
Merge branch 'master' into chore-refactor-schema-loader
256bd15
Add logging to conftest.
60a0f07
Refactor expoential time fn. Add unit test.
59dc1c4
Merge master.
b170235
Fix test fixture
994930c
xmarked errant test.
f974f66
Add custom descriptor loader to descriptor getter.
8fe7b99
Set a filename in Descriptor if none if provided.
578c39f
Feat: DescriptorGetter yields dirs and custom. Skips files with errors.
25c7150
Clean up code.
62010f4
DRM working.
63b3eff
Fix dockerfile for faster loads.
e9d3955
Rename loggers to correct names.
4533a0a
Clean up ORM factory
c6ae18e
Clean up loggers
db1ccf6
Clean up loggers
dd5994e
@loganripplinger loganripplinger marked this pull request as ready for review March 2, 2020 23:26
@loganripplinger loganripplinger merged commit 63f74df into master Mar 2, 2020
loganripplinger pushed a commit that referenced this pull request Mar 2, 2020
Fix DRM / Refactor schema loader (#55)
f606cfe 
* Adds a set of Descriptor classes.
* A DescriptorGetter class allows DMM/DRM to load both a list of directories and a list of descriptor dictionaries.
* Descriptor helper classes act as interfaces that encompass the relevant handling of the data type
* Dependency inject sqlalchemy base to enable testing
* Loads only json files - #44
* Add logging to conftest.
* Fixes DRM error.
@loganripplinger loganripplinger deleted the chore-refactor-schema-loader branch March 18, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@loganripplinger