Consider reverting commit 2265251

[ancestorak]

There has been negative feedback from users, the change clearly broke some people's habits and is causing them frustration. As there never were any requests to change the behaviour to begin with, I'm afraid this change was a bad decision.

[tanriol]

If I understand correctly, the problem is not commit a3726c3, but commit 2265251?

[tanriol]

If we revert it, we get at least two more problems to handle:

• relative URLs are not followed as the intercepting code does not take into account base URI
• new tabs do not seem to be children of Brief's tab, which breaks Tab Mix Plus and similar addons, see Open links in child tabs, if Tree Style Tab or Tab Kit 2nd Edition installed tanriol/digest#76 and https://addons.mozilla.org/en-US/firefox/addon/open-link-in-new-tab

Opening a link in a new tab without breaking anything is a nontrivial task.

[ancestorak]

Yes, I meant 2265251.

relative URLs are not followed as the intercepting code does not take into account base URI

Then let's make it do it, it's trivial.

new tabs do not seem to be children of Brief's tab, which breaks Tab Mix Plus and similar addons, see tanriol/digest#76 and https://addons.mozilla.org/en-US/firefox/addon/open-link-in-new-tab

There must be a way to fix it, we just need to use the exact same function as Firefox does to handle middle-clicks.

[tanriol]

we just need to use the exact same function as Firefox does to handle middle-clicks.

It seems to be handleLinkClick and functions called from it. Overridden by about half of these extensions each. Oh, and it takes the click event, which is immutable AFAIK.

[ancestorak]

I created issue #33 to figure out how to play nice with other extensions.

[kodawah]

I think I'm affected by this as well, even though I don't have tab management extensions.
Right now when a new tab opens it gets focus immediately, while I have exactly the opposite preference in my settings.

[tanriol]

@kodabb, pretty strange. Currently all links are forced to have target="_blank". Do such links in other tabs also behave the same way?

[ancestorak]

@tanriol, any comments on the pull request?