Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Year::atMonth(): deprecate int argument, add support for Month enum. #95

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Year::atMonth(): deprecate int argument, add support for Month enum. #95

merged 1 commit into from
Mar 21, 2024

Conversation

gnutix
Copy link
Contributor

@gnutix gnutix commented Mar 21, 2024 •
edited
Loading

Fixes #94

@gnutix gnutix mentioned this pull request Mar 21, 2024
Closed
gnutix
gnutix commented Mar 21, 2024
View reviewed changes
src/Year.php Show resolved Hide resolved
@BenMorel BenMorel merged commit 6c5ff2f into brick:master Mar 21, 2024
6 of 7 checks passed
@BenMorel
Copy link
Member

@gnutix Let's handle YearMonth::of() in another PR, if you will!

@gnutix
Copy link
Contributor Author

gnutix commented Mar 22, 2024

There you go : #96

@gnutix gnutix mentioned this pull request Mar 22, 2024
Merged
@BenMorel BenMorel added this to the 0.7 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenMorel BenMorel BenMorel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.1
Development

Successfully merging this pull request may close these issues.

Year::atMonth() should accept a Month
2 participants
@gnutix @BenMorel