Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call PHPUnit methods through self:: instead of $this-> #82

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Call PHPUnit methods through self:: instead of $this-> #82

merged 1 commit into from
Sep 25, 2023

Conversation

tigitz
Copy link
Contributor

@tigitz tigitz commented Sep 24, 2023

This is for preference.

Related to #77 (comment)

Note that custom assertX functions are not supported by the fixer, it only take into account PHPUnit ones.

I had to manually replace them to maintain consistency.

@BenMorel BenMorel merged commit 8988982 into brick:master Sep 25, 2023
7 checks passed
@BenMorel
Copy link
Member

Thank you, @tigitz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenMorel BenMorel BenMorel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tigitz @BenMorel