Merge pull request #76 from gnutix/optimize-min-max-of-methods

[performance] Optimize minOf/maxOf methods.
brick · Sep 15, 2023 · 5ac7c43 · 5ac7c43
2 parents c7c2107 + 0bf9233
commit 5ac7c43
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/src/LocalDate.php b/src/LocalDate.php
@@ -249,10 +249,10 @@ public static function minOf(LocalDate ...$dates): LocalDate
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $min = LocalDate::max();
+        $min = null;
 
         foreach ($dates as $date) {
-            if ($date->isBefore($min)) {
+            if ($min === null || $date->isBefore($min)) {
                 $min = $date;
             }
         }
@@ -275,10 +275,10 @@ public static function maxOf(LocalDate ...$dates): LocalDate
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $max = LocalDate::min();
+        $max = null;
 
         foreach ($dates as $date) {
-            if ($date->isAfter($max)) {
+            if ($max === null || $date->isAfter($max)) {
                 $max = $date;
             }
         }

diff --git a/src/LocalDateTime.php b/src/LocalDateTime.php
@@ -134,10 +134,10 @@ public static function minOf(LocalDateTime ...$times): LocalDateTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $min = LocalDateTime::max();
+        $min = null;
 
         foreach ($times as $time) {
-            if ($time->isBefore($min)) {
+            if ($min === null || $time->isBefore($min)) {
                 $min = $time;
             }
         }
@@ -160,10 +160,10 @@ public static function maxOf(LocalDateTime ...$times): LocalDateTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $max = LocalDateTime::min();
+        $max = null;
 
         foreach ($times as $time) {
-            if ($time->isAfter($max)) {
+            if ($max === null || $time->isAfter($max)) {
                 $max = $time;
             }
         }

diff --git a/src/LocalTime.php b/src/LocalTime.php
@@ -214,10 +214,10 @@ public static function minOf(LocalTime ...$times): LocalTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $min = LocalTime::max();
+        $min = null;
 
         foreach ($times as $time) {
-            if ($time->isBefore($min)) {
+            if ($min === null || $time->isBefore($min)) {
                 $min = $time;
             }
         }
@@ -240,10 +240,10 @@ public static function maxOf(LocalTime ...$times): LocalTime
             throw new DateTimeException(__METHOD__ . ' does not accept less than 1 parameter.');
         }
 
-        $max = LocalTime::min();
+        $max = null;
 
         foreach ($times as $time) {
-            if ($time->isAfter($max)) {
+            if ($max === null || $time->isAfter($max)) {
                 $max = $time;
             }
         }