Fix stop watching config on err #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 26, 2017 09:31
Add fix for config watch not using global config_key Update halt_on_change test to verify fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues.
The first is that the loop used to trigger a halt on change (-h) will stop watching for changes if an error is encountered. This can be be recreated by using the provided unit test or by...
Expected behavior is that git2consul will detect the modified config and quit since it continues to run. Actual behavior is that the modified config is ignored.
Second, while I was looking into this I saw that when the watcher is set up it used a hardcoded value for the key location. This would be problematic if an alternate config location (-c) was specified. I updated to use the global value (if available).