Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.2.0 #3

Merged
merged 16 commits into from
Apr 10, 2024
Merged

v0.2.0 #3

merged 16 commits into from
Apr 10, 2024

Conversation

brendancsmith
Copy link
Owner

Major bug fixes, new client methods, and functional tests.

Copy link

trunk-io bot commented Apr 6, 2024

❌ This pull request has been removed from the merge queue because it does not declare required statuses in either .trunk/trunk.yaml or your repo's branch protection rules for main. See more details here.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Sorry, something went wrong.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brendancsmith - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 4 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 4 issues found
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

.github/workflows/python-package.yml Show resolved Hide resolved
src/diffbot_kg/clients/enhance.py Show resolved Hide resolved
.trunk/trunk.yaml Outdated Show resolved Hide resolved
src/diffbot_kg/models/response/entities.py Show resolved Hide resolved
tests/unit/clients/test_search_client.py Show resolved Hide resolved
src/diffbot_kg/clients/base.py Show resolved Hide resolved
src/diffbot_kg/clients/base.py Show resolved Hide resolved
src/diffbot_kg/clients/base.py Show resolved Hide resolved
src/diffbot_kg/clients/base.py Show resolved Hide resolved
@brendancsmith brendancsmith linked an issue Apr 6, 2024 that may be closed by this pull request
@brendancsmith brendancsmith merged commit 343c56d into main Apr 10, 2024
4 checks passed
@brendancsmith brendancsmith deleted the dev branch April 10, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add integration tests
1 participant