Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unsubscribe Notification Definitions to LSP RPC #44

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Add Unsubscribe Notification Definitions to LSP RPC #44

merged 2 commits into from
Feb 29, 2024

Conversation

hydra-yse
Copy link
Member

@hydra-yse hydra-yse requested review from yaslama and JssDWt February 27, 2024 02:00
@hydra-yse hydra-yse force-pushed the yse-unsubscribe-webhook branch from 8719e27 to 9179d58 Compare February 27, 2024 02:11
@JssDWt
Copy link
Contributor

JssDWt commented Feb 27, 2024

lspd proto looks good.
This also needs a function mapping like this one https://github.com/breez/server/blob/main/lsp/lsp.go#L222-L242
And an update to the service definition exposed by breez server here: https://github.com/breez/server/blob/main/breez/breez.proto#L77-L79

JssDWt
JssDWt approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@JssDWt JssDWt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydra-yse hydra-yse merged commit e003460 into main Feb 29, 2024
@JssDWt JssDWt mentioned this pull request Feb 29, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JssDWt JssDWt JssDWt approved these changes

@yaslama yaslama Awaiting requested review from yaslama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hydra-yse @JssDWt