Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Boltz webhook handling #13

Merged
merged 1 commit into from
Aug 27, 2024
Merged

Add Boltz webhook handling #13

merged 1 commit into from
Aug 27, 2024

Conversation

dangeross
Copy link
Contributor

This PR adds SwapUpdatedPayload to handle Boltz webhook requests.

@roeierez Is it worth filtering out some of the status updates on the notifier, or let the Notification Plugin decide which to ignore? I imagine SwapCreated, InvoiceSet and potentially Mempool statuses could be ignored.

@dangeross dangeross requested a review from roeierez July 23, 2024 08:12
@roeierez
Copy link
Member

@dangeross yes we must filter those otherwise user will get lots of uselss push notifications.
I suggest also to open an issue in boltz repo to add the filter in the registration request. IMO it works well if we define only status updates that we are interested on.

Copy link
Contributor

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have one comment about a value on SwapUpdatedPayload.

http/router.go Show resolved Hide resolved
@dangeross dangeross merged commit 3062a1d into main Aug 27, 2024
1 check passed
@dangeross dangeross deleted the savage-swap-updated branch August 27, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants