-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect payment expiry changes #287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the scope of the PR only to reflect the SDK changes or do you plan to show the payment expiry time in the payment model also?
Don't know much about UI changes, but seems like a minor addition. I can add it if necessary. What do you think @roeierez? |
I think we should make it minimal only to have a build so we can test. Any additional features to misty can be done in a following PR outside the milestone. The main goal is to have today a build based on the sdk milestone so we can test and release RC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made suggestions to use WalletInfo
directly instead of GetInfoResponse
on methods of WebhookCubit
.
ℹ️: These changes may affect other parts of the code.
Co-authored-by: Erdem Yerebasmaz <[email protected]>
ab0abfe
to
10b69d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR:
GetInfoResponse
to use its new inner field of typeWalletInfo
liquidExpirationBlockheight
andbitcoinExpirationBlockheight
fields to the lightning and bitcoin payment details