Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect payment expiry changes #287

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Reflect payment expiry changes #287

merged 2 commits into from
Jan 8, 2025

Conversation

hydra-yse
Copy link
Member

This PR:

  • Changes the occurrences of GetInfoResponse to use its new inner field of type WalletInfo
  • Adds the liquidExpirationBlockheight and bitcoinExpirationBlockheight fields to the lightning and bitcoin payment details

Copy link
Contributor

@dangeross dangeross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the scope of the PR only to reflect the SDK changes or do you plan to show the payment expiry time in the payment model also?

@hydra-yse
Copy link
Member Author

Is the scope of the PR only to reflect the SDK changes or do you plan to show the payment expiry time in the payment model also?

Don't know much about UI changes, but seems like a minor addition. I can add it if necessary. What do you think @roeierez?

@roeierez
Copy link
Member

roeierez commented Jan 8, 2025

Is the scope of the PR only to reflect the SDK changes or do you plan to show the payment expiry time in the payment model also?

Don't know much about UI changes, but seems like a minor addition. I can add it if necessary. What do you think @roeierez?

I think we should make it minimal only to have a build so we can test. Any additional features to misty can be done in a following PR outside the milestone. The main goal is to have today a build based on the sdk milestone so we can test and release RC

Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggestions to use WalletInfo directly instead of GetInfoResponse on methods of WebhookCubit.

ℹ️: These changes may affect other parts of the code.

lib/cubit/webhook/webhook_cubit.dart Outdated Show resolved Hide resolved
lib/cubit/webhook/webhook_cubit.dart Outdated Show resolved Hide resolved
lib/cubit/webhook/webhook_cubit.dart Outdated Show resolved Hide resolved
lib/cubit/webhook/webhook_cubit.dart Outdated Show resolved Hide resolved
Copy link
Collaborator

@erdemyerebasmaz erdemyerebasmaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hydra-yse hydra-yse merged commit 2625e8e into main Jan 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants