Upgrade flutter, inappwebview, AGP and Android Compile SDK #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
force-pushed
the
upgrade-inappwebview-flutter-agp-compile-sdk
branch
from
7a1d4bc to
17962c5
Compare
danielgranhao
force-pushed
the
upgrade-inappwebview-flutter-agp-compile-sdk
branch
from
0ae21d6 to
1f4a270
Compare
- Update AGP to 8.2.1 - Bump Flutter SDK lower bound to 3.24.0
warning: [options] source value 8 is obsolete and will be removed in a future release warning: [options] target value 8 is obsolete and will be removed in a future release
- Log affected plugins - Group everything under single subprojects block
|
Thanks for taking the initiative @danielgranhao, changes look good! This was sth I was working on before my leave so I pulled some of my local changes and updates dependencies to latest resolvable versions. Changelist: |
Remove app_group_directory & uni_links from main pubspec file as they are not referenced on the app.
Multiple listeners are now allowed on events stream.
erdemyerebasmaz
force-pushed
the
upgrade-inappwebview-flutter-agp-compile-sdk
branch
from
c8435f9 to
b8fd62a
Compare
|
Added one last change:
@dangeross @danielgranhao We can do a final review. There won't be additional changes on my side in scope of this PR. |
- Apply changes to resource linking work around as well.
|
@roeierez @dangeross Thanks for the swift response. I have triggered new builds for: to be certain there are no mandatory changes we need to apply on breez-sdk-liquid. We can merge once they are both successful: |
|
LGTM - thank you for the help @erdemyerebasmaz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter_inappwebview: <6.1.0seems incompatible with the latest Xcode, failing with several errors similar to:Upgrading forced the upgrade of: