lsps2: framework for scid management #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JssDWt
changed the title
This was referenced Aug 13, 2023
Merged
There's a background watcher that scans the lightning node for in-use scids. These scids are cached in memory. There's a table containing the scids in use for the LSP. `ScidService.ReserveNewScid` attempts to reserve an unused scid. It tries a few times, just in case it runs into a collision. To tie this PR together into something working: - Initialize a `lightning.ScidCache` - Run `LightningClient.WatchScids` on either the CLN or LND client - Initialize a `jit.ScidCleaner` and start it - Initialize a `jit.ScidService` - Call `ScidService.ReserveNewScid` to reserve a scid
|
Closing this, because it's unnecessary due to #120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #72
There's a background watcher that scans the lightning node for in-use scids. These scids are cached in memory.
There's a table containing the scids in use for the LSP.
ScidService.ReserveNewScidattempts to reserve an unused scid. It tries a few times, just in case it runs into a collision.To tie this PR together into something working:
lightning.ScidCacheLightningClient.WatchScidson either the CLN or LND clientjit.ScidCleanerand start itjit.ScidServiceScidService.ReserveNewScidto reserve a scidOrder of pull requests: