Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a function to generate a unique SCID #72

Closed
JssDWt opened this issue Mar 20, 2023 · 1 comment
Closed

Create a function to generate a unique SCID #72

JssDWt opened this issue Mar 20, 2023 · 1 comment
Assignees

Comments

@JssDWt
Copy link
Collaborator

JssDWt commented Mar 20, 2023

In the proposed JIT channel spec a client gets assigned a unique SCID that is used to identify a payment as a JIT channel request.

There's a few options:

  1. Keep track of all SCIDs of open and pending channels and of pending JIT channel requests and make sure the new SCID does not yet exist.
  2. Reserve a range of numbers for JIT channel requests, so only JIT channel requests can have a SCID in that range. That way there's only JIT channel SCIDs to track.

Either way, the SCIDs have to be globally unique throughout the node. They have to be persisted on creation. So upon generating one, it has to be reserved until the expiration time.

@JssDWt
Copy link
Collaborator Author

JssDWt commented Oct 5, 2023

Closing: SCIDs are considered unique when generating, because the number space is so large.

@JssDWt JssDWt closed this as not planned Won't fix, can't repro, duplicate, stale Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant