Compare payment amount against maxPayableSat instead of balanceSat
#899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erdemyerebasmaz
force-pushed
the
max_payable_sats
branch
from
63ca0c7 to
8d3418e
Compare
erdemyerebasmaz
force-pushed
the
max_payable_sats
branch
from
8d3418e to
80c48f6
Compare
ok300
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the changes in
onchain_payment_limits: includemax_reverse_swap_amountin result breez-sdk-greenlight#1037minSat&maxSatare no longer returned as 0 when user has insufficient balance for the payment fromonchainPaymentLimits, a new fieldmaxPayableSatis added which denotes the maximum amount the node can send with it's current channels & local balance.If the payment amount falls within min-max limits, it is then compared against
maxPayableSatto validate if the payment can be made.