Add destination pubkey and bolt12 invoice to payment details #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangeross
requested review from
roeierez,
danielgranhao,
hydra-yse and
erdemyerebasmaz
danielgranhao
approved these changes
Jan 9, 2025
lib/core/src/model.rs
Outdated
Comment on lines
1880
to
1881
| #[macro_export] | ||
| macro_rules! get_invoice_destination_pubkey { |
There was a problem hiding this comment.
What's the motivation to use a macro here? Seems like a function would work
There was a problem hiding this comment.
You're right, fixed 18a7025
roeierez
approved these changes
Jan 9, 2025
hydra-yse
approved these changes
Jan 9, 2025
erdemyerebasmaz
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
destination_pubkeybolt11toinvoiceto expose both bolt11 and bolt12 invoicesDepends on breez/breez-sdk-greenlight#1156
Fixes #646
Fixes #648