Skip to content
This repository has been archived by the owner on Jan 29, 2020. It is now read-only.

Use newer S3 node package to patch security vulnerability with mime < 1.4.1 #10

Merged
merged 1 commit into from
Aug 15, 2018

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Aug 14, 2018

Fixes #9

I tested by running the following command locally, which uses release-tools to upload the Brave Dark Theme extension to S3:

node bin/updateExtensions.js \
     --chromium=0.0.0.0 \
     --id bfdgpgibhagkpdlnjonhkabjoijopoge \
     --location=../vault-updater/data \
     --path=c:/mongoose/bfdgpgibhagkpdlnjonhkabjoijopoge/extension_1_0_0.crx \
     --version=1.0.0 \
     --v=2

@emerick
Copy link
Contributor Author

emerick commented Aug 14, 2018

@aekeus / @bsclifton This is to address a security vulnerability in mime 1.4.1, see #9 for additional details. I don't have permission to add a reviewer to this it seems, but was hoping one of you could take a look.

@bsclifton bsclifton requested review from aekeus and bsclifton August 14, 2018 22:53
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - once merged, we can easily test by doing browser-laptop builds

@emerick
Copy link
Contributor Author

emerick commented Aug 15, 2018

Thanks @bsclifton!

@aekeus aekeus merged commit 157a84f into brave:master Aug 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants